Initial flutter android build #4

Merged
Henry-Hiles merged 3 commits from zaaach/nexus:android into main 2026-03-23 22:56:40 -04:00
Contributor

Alright I got the build process running. Couple things came up some of which we discussed:

  1. Leveraging goolm, I made that change here but we'll need to test it in windows/linux
  2. It also seems heic isnt supported in the android builds. Would probably need to be looked at upstream, for now I just disabled in the android build
  3. Added some mobile/desktop checks to the main.dart to prevent crashes
  4. Add's root passthrough to GomuksInit - depends on: https://github.com/gomuks/gomuks/pull/702
Alright I got the build process running. Couple things came up some of which we discussed: 1. Leveraging `goolm`, I made that change here but we'll need to test it in windows/linux 2. It also seems `heic` isnt supported in the android builds. Would probably need to be looked at [upstream](https://github.com/tulir/goheif), for now I just disabled in the android build 3. Added some mobile/desktop checks to the main.dart to prevent crashes 4. Add's root passthrough to `GomuksInit` - depends on: https://github.com/gomuks/gomuks/pull/702
Henry-Hiles requested changes 2026-03-20 21:10:34 -04:00
Dismissed
Henry-Hiles left a comment
Owner

Looks good other than nitpicks. Let's get those functions that aren't needed with nix removed, and lets get launch working, then good to merge!

Looks good other than nitpicks. Let's get those functions that aren't needed with nix removed, and lets get launch working, then good to merge!
@ -64,2 +62,2 @@
WindowOptions(titleBarStyle: TitleBarStyle.hidden),
);
if (Platform.isLinux || Platform.isMacOS || Platform.isWindows) {
await windowManager.ensureInitialized();
Owner

Changes may also be needed in widgets/appbar.dart, specifically the onPanStart callback, but it may just be ignored as is. We can test once launch works.

Changes may also be needed in `widgets/appbar.dart`, specifically the `onPanStart` callback, but it may just be ignored as is. We can test once launch works.
Author
Contributor

I tested it and i'm not seeing these fire. I'm not seeing an app bar. I'll follow up if we see issues but it seems good.

I tested it and i'm not seeing these fire. I'm not seeing an app bar. I'll follow up if we see issues but it seems good.
Henry-Hiles left a comment
Owner

LGTM, can iterate further later

LGTM, can iterate further later
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Henry-Hiles/nexus!4
No description provided.