Initial flutter android build #4
No reviewers
Labels
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Henry-Hiles/nexus!4
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "zaaach/nexus:android"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Alright I got the build process running. Couple things came up some of which we discussed:
goolm, I made that change here but we'll need to test it in windows/linuxheicisnt supported in the android builds. Would probably need to be looked at upstream, for now I just disabled in the android buildGomuksInit- depends on: https://github.com/gomuks/gomuks/pull/702Looks good other than nitpicks. Let's get those functions that aren't needed with nix removed, and lets get launch working, then good to merge!
@ -64,2 +62,2 @@WindowOptions(titleBarStyle: TitleBarStyle.hidden),);if (Platform.isLinux || Platform.isMacOS || Platform.isWindows) {await windowManager.ensureInitialized();Changes may also be needed in
widgets/appbar.dart, specifically theonPanStartcallback, but it may just be ignored as is. We can test once launch works.I tested it and i'm not seeing these fire. I'm not seeing an app bar. I'll follow up if we see issues but it seems good.
LGTM, can iterate further later