Henry-Hiles/qmk_userspace
1
0
Fork 0
forked from mirrors/qmk_userspace
Code Pull requests Activity

dynamic_macro.h: Fix an off-by-two error

Browse source 
We need to check whether we just passed the after-the-end point of the
other macro. Instead we were checking whether we are going to reach it
now.
This commit is contained in:
Wojciech Siewierski 2017-05-04 01:19:05 +02:00
commit 436d661775
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
quantum/dynamic_macro.h
View file

@ -99,14 +99,14 @@ void dynamic_macro_play(
* *
* @param macro_buffer[in] The start of the used macro buffer. * @param macro_buffer[in] The start of the used macro buffer.
* @param macro_pointer[in,out] The current buffer position. * @param macro_pointer[in,out] The current buffer position.
* @param macro_end2[in] The end of the other macro which shouldn't be overwritten. * @param macro2_end[in] The last buffer element it is safe to use before overwriting the other macro.
* @param direction[in] Either +1 or -1, which way to iterate the buffer. * @param direction[in] Either +1 or -1, which way to iterate the buffer.
* @param record[in] The current keypress. * @param record[in] The current keypress.
*/ */
void dynamic_macro_record_key( void dynamic_macro_record_key(
keyrecord_t *macro_buffer, keyrecord_t *macro_buffer,
keyrecord_t **macro_pointer, keyrecord_t **macro_pointer,
keyrecord_t *macro_end2, keyrecord_t *macro2_end,
int8_t direction, int8_t direction,
keyrecord_t *record) keyrecord_t *record)
{ {
@ -115,7 +115,7 @@ void dynamic_macro_record_key(
return; return;
} }
if (*macro_pointer + direction != macro_end2) { if (*macro_pointer - direction != macro2_end) {
**macro_pointer = *record; **macro_pointer = *record;
*macro_pointer += direction; *macro_pointer += direction;
} else { } else {