- Toronto, Canada
- https://henryhiles.com
-
Joined on
2025-03-25
Lets take in final Uri homeserver as an argument here, instead of using ClientStateController.
I don't think this logic needs to be changed this much. If you can keep the previous logic, but instead show ServerSelectPage instead of login, we can take a different approach to push the login.
Given this won't be persistent anyways, I think we can go for a simpler approach and not touch client state controller.
I'd appreciate if you didn't commit these changes.
Instead of setting homeserver in client state controller, can we just Navigator.of(context).push the LoginPage, passing in a homeserver as an argument?
This padding should be removed entirely now theres nothing below it. When loading, the whole page should be replaced by a loading indicator, not just at the bottom.
Closed as I will be exploring other solutions to this issue, as this came with multiple issues that are not trivial to solve.