Nexus/nexus
Nexus/nexus
Watch
2
5
Fork
You've already forked nexus
 7
Code Issues 29 Pull requests Releases Activity

make it more clear which methods free the buffer

Browse source
This commit is contained in:
Henry Hiles 2026-10-05 10:11:16 -04:00
commit 02c486e1b3
Signed by: Henry-Hiles
SSH key fingerprint: SHA256:VKQUdS31Q90KvX7EkKMHMBpUspcmItAh86a+v7PGiIs
3 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/controllers/client.dart
View file

@ -108,7 +108,7 @@ class ClientController extends AsyncNotifier<int> {
() => callback(handle, bufferPointer.ref), () => callback(handle, bufferPointer.ref),
); );
final json = response.buf.toJson(); final json = response.buf.toJsonAndFree();
if (response.command.cast<Utf8>().toDartString() == "error") { if (response.command.cast<Utf8>().toDartString() == "error") {
throw json; throw json;

2
lib/controllers/gomuks_listener.dart
View file

@ -35,7 +35,7 @@ class GomuksListenerController extends AsyncNotifier<void> {
try { try {
final muksEventType = command.cast<Utf8>().toDartString(); final muksEventType = command.cast<Utf8>().toDartString();
debugPrint("Handling $muksEventType..."); debugPrint("Handling $muksEventType...");
final decodedMuksEvent = data.toJson(); final decodedMuksEvent = data.toJsonAndFree();
switch (muksEventType) { switch (muksEventType) {
case "client_state": case "client_state":

7
lib/helpers/extensions/gomuks_buffer.dart
View file

@ -1,20 +1,21 @@
import "dart:convert"; import "dart:convert";
import "dart:ffi"; import "dart:ffi";
import "dart:typed_data"; import "dart:typed_data";
import "package:ffi/ffi.dart"; import "package:ffi/ffi.dart";
import "package:nexus/src/third_party/gomuks.g.dart"; import "package:nexus/src/third_party/gomuks.g.dart";
extension GomuksOwnedBufferToX on GomuksOwnedBuffer { extension GomuksOwnedBufferToX on GomuksOwnedBuffer {
Uint8List toBytes() { Uint8List toBytesAndFree() {
try { try {
if (base == nullptr || length <= 0) return .new(0); if (base == nullptr || length <= 0) return .new(0);
return .fromList(base.asTypedList(length)); return .fromList(base.asTypedList(length));
} finally { } finally {
calloc.free(base); GomuksFreeBuffer(this);
} }
} }
dynamic toJson() => jsonDecode(utf8.decode(toBytes())); dynamic toJsonAndFree() => jsonDecode(utf8.decode(toBytesAndFree()));
} }
extension JsonToGomuksBuffer on Map<String, dynamic> { extension JsonToGomuksBuffer on Map<String, dynamic> {