Nexus/nexus
Nexus/nexus
Watch
3
6
Fork
You've already forked nexus
 8
Code Issues 22 Pull requests Releases 8 Activity

try to fix disposed errors when ending poll

Browse source
This commit is contained in:
Henry Hiles 2026-11-03 14:26:53 -05:00
commit 2580cc8c1c
Signed by: Henry-Hiles
SSH key fingerprint: SHA256:VKQUdS31Q90KvX7EkKMHMBpUspcmItAh86a+v7PGiIs
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/controllers/room_chat.dart
View file

@ -466,6 +466,8 @@ class RoomChatController(final ChatParams info)
EventType type, EventType type,
Content content, Content content,
) async { ) async {
// The end event lands in the timeline and rebuilds this, so no ref after awaiting
final rooms = ref.read(RoomsController.provider.notifier);
final event = await ref final event = await ref
.read(ClientController.provider.notifier) .read(ClientController.provider.notifier)
.sendEvent( .sendEvent(
@ -481,9 +483,7 @@ class RoomChatController(final ChatParams info)
if (event.sendFailed) throw Exception(event.sendError); if (event.sendFailed) throw Exception(event.sendError);
await ref await rooms.awaitEvent(info.roomId, event.eventId);
.read(RoomsController.provider.notifier)
.awaitEvent(info.roomId, event.eventId);
} }
/// An empty [answers] removes the vote. /// An empty [answers] removes the vote.

1
lib/widgets/renderers/poll.dart
View file

@ -75,6 +75,7 @@ class const PollRenderer(final Event event, final PollStart poll, {super.key})
) async { ) async {
pending.value = action; pending.value = action;
await send().onError(showError); await send().onError(showError);
if (!context.mounted) return;
// Otherwise the old votes show until they're refetched // Otherwise the old votes show until they're refetched
await ref.read(votesProvider.future).onError((_, _) => const .new()); await ref.read(votesProvider.future).onError((_, _) => const .new());
if (context.mounted) pending.value = null; if (context.mounted) pending.value = null;