From 29157c725214f894bac5b8acd71b41013a1aa3f0 Mon Sep 17 00:00:00 2001 From: Henry-Hiles Date: Tue, 2 Jun 2026 19:47:51 -0400 Subject: [PATCH] do not reverse the scrollview --- lib/controllers/room_chat_controller.dart | 13 ++--- lib/widgets/room_chat.dart | 60 +++++++++++++++-------- 2 files changed, 44 insertions(+), 29 deletions(-) diff --git a/lib/controllers/room_chat_controller.dart b/lib/controllers/room_chat_controller.dart index 03caa04..7e7eebc 100644 --- a/lib/controllers/room_chat_controller.dart +++ b/lib/controllers/room_chat_controller.dart @@ -38,16 +38,11 @@ class RoomChatController extends AsyncNotifier> { loadOlder(); } - return IMap.fromValues( - keyMapper: (id) => 9999999999 + (id ?? 0), - values: room.sticky, - ) - .addAll(room.timeline) - .toEntryIList(compare: (a, b) => (b?.key ?? 0).compareTo(a?.key ?? 0)) + return room.timeline + .toValueIList(sort: true, compare: (a, b) => (a ?? 0).compareTo(b ?? 0)) + .addAll(room.sticky) .map((entry) { - final foundEvent = entry.value == null - ? null - : room.events[entry.value!]; + final foundEvent = entry == null ? null : room.events[entry]; final editedEvent = foundEvent == null || foundEvent.lastEditRowId == 0 diff --git a/lib/widgets/room_chat.dart b/lib/widgets/room_chat.dart index 95e7514..d8664b1 100644 --- a/lib/widgets/room_chat.dart +++ b/lib/widgets/room_chat.dart @@ -77,6 +77,29 @@ class RoomChat extends HookConsumerWidget { final listController = useRef(ListController()); final scrollController = useScrollController(); + final controllerData = ref.watch(controllerProvider); + + useEffect(() { + WidgetsBinding.instance.addPostFrameCallback((_) { + if (scrollController.hasClients) { + scrollController.jumpTo(scrollController.position.maxScrollExtent); + } + }); + + return null; + }, [scrollController.hasClients]); + + useEffect(() { + if (scrollController.position.atEdge && + scrollController.position.pixels != 0) { + WidgetsBinding.instance.addPostFrameCallback((_) { + if (scrollController.hasClients) { + scrollController.jumpTo(scrollController.position.maxScrollExtent); + } + }); + } + return null; + }, [controllerData]); useEffect(() { Future listener() async { @@ -88,9 +111,9 @@ class RoomChat extends HookConsumerWidget { if (room == null) return; if (scrollController.position.pixels == 0) { - await client.markRead(room); - } else { if (room.hasMore) await notifier.loadOlder(); + } else { + await client.markRead(room); } } @@ -316,8 +339,6 @@ class RoomChat extends HookConsumerWidget { ].toIList(); } - final controllerData = ref.watch(controllerProvider); - return Scaffold( appBar: RoomAppbar( roomId: roomId, @@ -339,11 +360,20 @@ class RoomChat extends HookConsumerWidget { child: switch (controllerData) { AsyncData(:final value) || AsyncLoading(:final value?) => CustomScrollView( - reverse: true, controller: scrollController, slivers: [ - SliverPadding( - padding: .only(bottom: composerSize.value), + SliverToBoxAdapter( + child: Padding( + padding: .symmetric(vertical: 36), + child: Center( + child: ElevatedButton( + onPressed: controllerData is AsyncData + ? notifier.loadOlder + : null, + child: Text("Load More"), + ), + ), + ), ), SuperSliverList.builder( @@ -351,7 +381,7 @@ class RoomChat extends HookConsumerWidget { itemCount: value.length, itemBuilder: (_, index) { final event = value[index]; - final previousEvent = value.getOrNull(index + 1); + final previousEvent = value.getOrNull(index - 1); return FlashWrapper( EventRenderer( event, @@ -389,18 +419,8 @@ class RoomChat extends HookConsumerWidget { }, ), - SliverToBoxAdapter( - child: Padding( - padding: .symmetric(vertical: 36), - child: Center( - child: controllerData is AsyncLoading - ? Loading() - : ElevatedButton( - onPressed: notifier.loadOlder, - child: Text("Load More"), - ), - ), - ), + SliverPadding( + padding: .only(bottom: composerSize.value), ), ], ),