Nexus/nexus
Nexus/nexus
Watch
3
6
Fork
You've already forked nexus
 8
Code Issues 22 Pull requests Releases 10 Activity Actions

timeline fixups

Browse source
This commit is contained in:
Henry Hiles 2026-11-09 10:58:08 -05:00
commit ac31fbb74d
Signed by: Henry-Hiles
SSH key fingerprint: SHA256:VKQUdS31Q90KvX7EkKMHMBpUspcmItAh86a+v7PGiIs
1 changed files with 46 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

40
lib/helpers/hooks/chat_scroll.dart
View file

@ -9,6 +9,14 @@ import "package:nexus/models/room_chat.dart";
typedef JumpToEvent = Future<void> Function(int rowId);
/// Identifies the row for the event with [rowId], so it can be found to
/// scroll to it, and keeps its element when rows are added before it.
final class EventRowKey extends GlobalKey {
EventRowKey(this.rowId) : super.constructor();
final int rowId;
}
final class ChatScroll({
required final IList<int> historyRows,
required final IList<int> liveRows,
@ -20,7 +28,7 @@ final class ChatScroll({
required final JumpToEvent jumpToEvent,
required final Future<void> Function() jumpToBottom,
required final GlobalKey Function(int eventRowId) keyFor,
required final EventRowKey Function(int eventRowId) keyFor,
}) {
factory use({
required AsyncValue<RoomChat?> controllerData,
@ -42,9 +50,9 @@ final class ChatScroll({
final scrollController = useScrollController();
final centerKey = useMemoized(GlobalKey.new);
final itemKeys = useMemoized(() => <int, GlobalKey>{}, []);
GlobalKey keyFor(int eventRowId) =>
itemKeys.putIfAbsent(eventRowId, GlobalKey.new);
final itemKeys = useMemoized(() => <int, EventRowKey>{}, []);
EventRowKey keyFor(int eventRowId) =>
itemKeys.putIfAbsent(eventRowId, () => EventRowKey(eventRowId));
useEffect(() {
if (anchorId.value == null) {
@ -117,6 +125,22 @@ final class ChatScroll({
final lastRowId = controllerData.value?.timeline.lastOrNull;
final previousLastRowId = useRef<int?>(null);
void updateAtBottom() {
if (!hookContext.mounted || !scrollController.hasClients) return;
final position = scrollController.position;
final isAtBottom = position.extentBefore <= 0;
if (isAtBottom != atBottom.value) {
// TODO: remove, debugging replies not showing
debugPrint(
"[timeline] atBottom: $isAtBottom pixels=${position.pixels} "
"min=${position.minScrollExtent} anchor=${anchorId.value} "
"live=${split.live.length}",
);
atBottom.value = isAtBottom;
}
}
useEffect(() {
final previous = previousLastRowId.value;
previousLastRowId.value = lastRowId;
@ -141,6 +165,10 @@ final class ChatScroll({
anchorId.value = lastRowId;
scrollController.position.correctPixels(0);
// Other callbacks this frame still see the new event below the old
// anchor, so they think it isn't at the bottom until the next frame
WidgetsBinding.instance.addPostFrameCallback((_) => updateAtBottom());
});
return null;
@ -154,9 +182,7 @@ final class ChatScroll({
if (!scrollController.hasClients) return;
final position = scrollController.position;
final isAtBottom = position.extentBefore <= 0;
if (isAtBottom != atBottom.value) atBottom.value = isAtBottom;
updateAtBottom();
// contextualEvent updates immediately when jumping, but
// controllerData is only for the historical timeline once it loads