Don't reverse the CustomScrollView #34

Manually merged
Henry-Hiles merged 4 commits from non-reversed-scroll-view into main 2026-06-02 21:10:02 -04:00
2 changed files with 85 additions and 31 deletions

View file

@ -38,16 +38,13 @@ class RoomChatController extends AsyncNotifier<IList<Event>> {
loadOlder(); loadOlder();
} }
return IMap<int, int?>.fromValues( return room.timeline
keyMapper: (id) => 9999999999 + (id ?? 0), .toEntryIList(compare: (a, b) => (a?.key ?? 0).compareTo(b?.key ?? 0))
values: room.sticky, .map((element) => element.value)
) .toIList()
.addAll(room.timeline) .addAll(room.sticky)
.toEntryIList(compare: (a, b) => (b?.key ?? 0).compareTo(a?.key ?? 0))
.map((entry) { .map((entry) {
final foundEvent = entry.value == null final foundEvent = entry == null ? null : room.events[entry];
? null
: room.events[entry.value!];
final editedEvent = final editedEvent =
foundEvent == null || foundEvent.lastEditRowId == 0 foundEvent == null || foundEvent.lastEditRowId == 0

View file

@ -77,10 +77,68 @@ class RoomChat extends HookConsumerWidget {
final listController = useRef(ListController()); final listController = useRef(ListController());
final scrollController = useScrollController(); final scrollController = useScrollController();
final controllerData = ref.watch(controllerProvider);
final topEventBeforeLoad = useState<String?>(null);
Future<void> loadOlder() async {
if (controllerData
case AsyncData(:final value) || AsyncLoading(:final value?)) {
topEventBeforeLoad.value = value.firstOrNull?.eventId;
await notifier.loadOlder();
}
}
useEffect(() {
WidgetsBinding.instance.addPostFrameCallback((_) {
if (scrollController.hasClients) {
scrollController.jumpTo(scrollController.position.maxScrollExtent);
}
});
return null;
}, [scrollController.hasClients]);
useEffect(() {
if (controllerData case AsyncData(
:final value,
) when scrollController.hasClients) {
if (topEventBeforeLoad.value != null) {
WidgetsBinding.instance.addPostFrameCallback((_) {
if (scrollController.hasClients) {
final index = value.indexWhere(
(event) => event.eventId == topEventBeforeLoad.value,
);
if (index != -1) {
listController.value.jumpToItem(
index: index,
scrollController: scrollController,
alignment: 0,
);
}
}
topEventBeforeLoad.value = null;
});
} else if (scrollController.position.atEdge &&
scrollController.position.pixels != 0) {
WidgetsBinding.instance.addPostFrameCallback((_) {
if (scrollController.hasClients) {
scrollController.jumpTo(
scrollController.position.maxScrollExtent,
);
}
});
}
}
return null;
}, [controllerData]);
useEffect(() { useEffect(() {
Future<void> listener() async { Future<void> listener() async {
if (!scrollController.position.atEdge) return; if (!scrollController.hasClients || !scrollController.position.atEdge) {
return;
}
final room = ref.watch( final room = ref.watch(
RoomsController.provider.select((value) => value[roomId]), RoomsController.provider.select((value) => value[roomId]),
@ -88,15 +146,17 @@ class RoomChat extends HookConsumerWidget {
if (room == null) return; if (room == null) return;
if (scrollController.position.pixels == 0) { if (scrollController.position.pixels == 0) {
await client.markRead(room); if (room.hasMore) {
await loadOlder();
}
} else { } else {
if (room.hasMore) await notifier.loadOlder(); await client.markRead(room);
} }
} }
scrollController.addListener(listener); scrollController.addListener(listener);
return () => scrollController.removeListener(listener); return () => scrollController.removeListener(listener);
}, [roomId]); }, [roomId, controllerData]);
final composerNode = useFocusNode( final composerNode = useFocusNode(
onKeyEvent: (_, event) { onKeyEvent: (_, event) {
@ -316,8 +376,6 @@ class RoomChat extends HookConsumerWidget {
].toIList(); ].toIList();
} }
final controllerData = ref.watch(controllerProvider);
return Scaffold( return Scaffold(
appBar: RoomAppbar( appBar: RoomAppbar(
roomId: roomId, roomId: roomId,
@ -339,11 +397,20 @@ class RoomChat extends HookConsumerWidget {
child: switch (controllerData) { child: switch (controllerData) {
AsyncData(:final value) || AsyncData(:final value) ||
AsyncLoading(:final value?) => CustomScrollView( AsyncLoading(:final value?) => CustomScrollView(
reverse: true,
controller: scrollController, controller: scrollController,
slivers: [ slivers: [
SliverPadding( SliverToBoxAdapter(
padding: .only(bottom: composerSize.value), child: Padding(
padding: .symmetric(vertical: 36),
child: Center(
child: ElevatedButton(
onPressed: controllerData is AsyncData
? loadOlder
: null,
child: Text("Load More"),
),
),
),
), ),
SuperSliverList.builder( SuperSliverList.builder(
@ -351,7 +418,7 @@ class RoomChat extends HookConsumerWidget {
itemCount: value.length, itemCount: value.length,
itemBuilder: (_, index) { itemBuilder: (_, index) {
final event = value[index]; final event = value[index];
final previousEvent = value.getOrNull(index + 1); final previousEvent = value.getOrNull(index - 1);
return FlashWrapper( return FlashWrapper(
EventRenderer( EventRenderer(
event, event,
@ -389,18 +456,8 @@ class RoomChat extends HookConsumerWidget {
}, },
), ),
SliverToBoxAdapter( SliverPadding(
child: Padding( padding: .only(bottom: composerSize.value),
padding: .symmetric(vertical: 36),
child: Center(
child: controllerData is AsyncLoading
? Loading()
: ElevatedButton(
onPressed: notifier.loadOlder,
child: Text("Load More"),
),
),
),
), ),
], ],
), ),