From 69312e9b9884ac9293fe3b0b9936a104b7d04331 Mon Sep 17 00:00:00 2001 From: Henry-Hiles Date: Fri, 5 Jun 2026 14:36:22 -0400 Subject: [PATCH 1/7] improve UI of member list, sort by power level --- .../members_grouped_controller.dart | 49 +++++++++ lib/widgets/member_list.dart | 99 +++++++++++-------- pubspec.lock | 8 ++ pubspec.yaml | 1 + 4 files changed, 114 insertions(+), 43 deletions(-) create mode 100644 lib/controllers/members_grouped_controller.dart diff --git a/lib/controllers/members_grouped_controller.dart b/lib/controllers/members_grouped_controller.dart new file mode 100644 index 0000000..1fc17a6 --- /dev/null +++ b/lib/controllers/members_grouped_controller.dart @@ -0,0 +1,49 @@ +import "package:fast_immutable_collections/fast_immutable_collections.dart"; +import "package:flutter_riverpod/flutter_riverpod.dart"; +import "package:nexus/controllers/members_by_status_controller.dart"; +import "package:nexus/controllers/rooms_controller.dart"; +import "package:nexus/models/configs/members_by_status_config.dart"; +import "package:nexus/models/content/content.dart"; +import "package:nexus/models/content/power_levels.dart"; +import "package:nexus/models/event.dart"; + +class MembersGroupedController extends AsyncNotifier>> { + final MembersByStatusConfig config; + MembersGroupedController(this.config); + + @override + Future>> build() async { + final event = ref.watch( + RoomsController.provider.select((value) { + final room = value[config.roomId]; + final eventRowId = room?.state[EventType.powerLevels.type]?[""]; + return eventRowId == null ? null : room?.events[eventRowId]; + }), + ); + + final content = event?.content is PowerLevelsContent + ? event!.content as PowerLevelsContent + : PowerLevelsContent(); + + final members = await ref.watch( + MembersByStatusController.provider(config).future, + ); + + return members.fold>>(.new(), (result, event) { + final groupKey = content.users[event.stateKey!] ?? content.usersDefault; + + return result.update( + groupKey, + (value) => value.add(event), + ifAbsent: () => .new({event}), + ); + }); + } + + static final provider = + AsyncNotifierProvider.family< + MembersGroupedController, + IMap>, + MembersByStatusConfig + >(MembersGroupedController.new); +} diff --git a/lib/widgets/member_list.dart b/lib/widgets/member_list.dart index 00633a7..f80f403 100644 --- a/lib/widgets/member_list.dart +++ b/lib/widgets/member_list.dart @@ -1,13 +1,14 @@ import "package:flutter/material.dart"; import "package:flutter_hooks/flutter_hooks.dart"; import "package:hooks_riverpod/hooks_riverpod.dart"; -import "package:nexus/controllers/members_by_status_controller.dart"; +import "package:material_segmented_list/material_segmented_list.dart"; +import "package:nexus/controllers/members_grouped_controller.dart"; import "package:nexus/helpers/extensions/get_localpart.dart"; -import "package:nexus/helpers/extensions/show_user_popover.dart"; import "package:nexus/helpers/extensions/string_to_color.dart"; import "package:nexus/models/content/membership.dart"; import "package:nexus/models/membership_status.dart"; import "package:nexus/widgets/avatar_or_hash.dart"; +import "package:nexus/widgets/divider_text.dart"; import "package:nexus/widgets/error_dialog.dart"; import "package:nexus/widgets/loading.dart"; @@ -18,11 +19,6 @@ class MemberList extends HookConsumerWidget { @override Widget build(BuildContext context, WidgetRef ref) { final status = useState(MembershipStatus.join); - final membersProvider = ref.watch( - MembersByStatusController.provider( - .new(roomId: roomId, status: status.value), - ), - ); return Drawer( shape: Border(), @@ -64,50 +60,67 @@ class MemberList extends HookConsumerWidget { ), ], ), - switch (membersProvider) { + switch (ref.watch( + MembersGroupedController.provider( + .new(roomId: roomId, status: status.value), + ), + )) { AsyncError(:final error, :final stackTrace) => ErrorDialog( error, stackTrace, ), AsyncData(:final value) || AsyncLoading(:final value?) => Expanded( child: ListView( - children: value - .map( - (member) => switch (member.content) { - MembershipContent( - :final avatarUrl, - :final displayName, - ) => - InkWell( - onTapUp: (details) => context.showUserPopover( - member.content as MembershipContent, - member.stateKey!, - roomId: roomId, - globalPosition: details.globalPosition, - ), - child: ListTile( - leading: AvatarOrHash( - avatarUrl, - displayName ?? member.sender.localpart, - ), - title: Text( - displayName ?? member.stateKey!.localpart, - overflow: .ellipsis, - style: .new( - color: member.stateKey!.colorHash, - fontWeight: .bold, + padding: .all(12), + children: [ + for (final MapEntry(key: powerLevel, value: members) + in value.toEntryIList( + compare: (a, b) => (b?.key ?? double.negativeInfinity) + .compareTo(a?.key ?? double.negativeInfinity), + )) ...[ + DividerText("Power Level $powerLevel"), + SegmentedListSection( + children: members + .map( + (member) => switch (member.content) { + MembershipContent( + :final avatarUrl, + :final displayName, + ) => + SegmentedListTile( + onTap: () {}, + // context.showUserPopover( + // member.content as MembershipContent, + // member.stateKey!, + // roomId: roomId, + // globalPosition: details.globalPosition, + // ), + title: Text( + displayName ?? member.stateKey!.localpart, + overflow: .ellipsis, + style: .new( + color: member.stateKey!.colorHash, + fontWeight: .bold, + ), + ), + subtitle: Text( + member.stateKey!, + overflow: .ellipsis, + ), + leading: AvatarOrHash( + avatarUrl, + displayName ?? member.sender.localpart, + ), ), + _ => throw Exception( + "Member content was not MembershipContent", ), - subtitle: Text( - member.stateKey!, - overflow: .ellipsis, - ), - ), - ), - _ => SizedBox.shrink(), - }, - ) - .toList(), + }, + ) + .toList(), + ), + ], + ], ), ), AsyncLoading _ => Loading(), diff --git a/pubspec.lock b/pubspec.lock index 108474b..dc5230a 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -760,6 +760,14 @@ packages: url: "https://pub.dev" source: hosted version: "0.13.0" + material_segmented_list: + dependency: "direct main" + description: + name: material_segmented_list + sha256: "384bfd41a78e745397ceff1dd39700961e6a5419ad911d1797bcc13ea3824241" + url: "https://pub.dev" + source: hosted + version: "1.0.5" measure_size: dependency: "direct main" description: diff --git a/pubspec.yaml b/pubspec.yaml index 0ce2a30..a2a2036 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -64,6 +64,7 @@ dependencies: media_kit_video: 2.0.1 media_kit_libs_video: 1.0.7 measure_size: ^5.0.2 + material_segmented_list: ^1.0.5 dev_dependencies: build_runner: 2.15.0 -- 2.54.0 From 035cd920f69944311d1fdf5e91b35799c6a6e765 Mon Sep 17 00:00:00 2001 From: Henry-Hiles Date: Fri, 5 Jun 2026 14:52:01 -0400 Subject: [PATCH 2/7] add support for v12 creators --- .../members_grouped_controller.dart | 43 +++++++++++++------ lib/models/content/create.dart | 2 - lib/widgets/member_list.dart | 10 +++-- 3 files changed, 36 insertions(+), 19 deletions(-) diff --git a/lib/controllers/members_grouped_controller.dart b/lib/controllers/members_grouped_controller.dart index 1fc17a6..7cec625 100644 --- a/lib/controllers/members_grouped_controller.dart +++ b/lib/controllers/members_grouped_controller.dart @@ -4,33 +4,48 @@ import "package:nexus/controllers/members_by_status_controller.dart"; import "package:nexus/controllers/rooms_controller.dart"; import "package:nexus/models/configs/members_by_status_config.dart"; import "package:nexus/models/content/content.dart"; +import "package:nexus/models/content/create.dart"; import "package:nexus/models/content/power_levels.dart"; import "package:nexus/models/event.dart"; -class MembersGroupedController extends AsyncNotifier>> { +class MembersGroupedController extends AsyncNotifier>> { final MembersByStatusConfig config; MembersGroupedController(this.config); @override - Future>> build() async { - final event = ref.watch( - RoomsController.provider.select((value) { - final room = value[config.roomId]; - final eventRowId = room?.state[EventType.powerLevels.type]?[""]; - return eventRowId == null ? null : room?.events[eventRowId]; - }), + Future>> build() async { + final room = ref.watch( + RoomsController.provider.select((value) => value[config.roomId]), ); - final content = event?.content is PowerLevelsContent - ? event!.content as PowerLevelsContent - : PowerLevelsContent(); + final createRowId = room?.state[EventType.create.type]?[""]; + final createEvent = createRowId == null ? null : room?.events[createRowId]; + final createEventContent = switch (createEvent?.content) { + CreateContent content => content, + _ => null, + }; + final creators = createEventContent?.additionalCreatorIds.add( + createEvent!.sender, + ); + + final powerLevelsRowId = room?.state[EventType.powerLevels.type]?[""]; + final powerLevelsEvent = powerLevelsRowId == null + ? null + : room?.events[powerLevelsRowId]; + + final content = switch (powerLevelsEvent?.content) { + PowerLevelsContent content => content, + _ => PowerLevelsContent(), + }; final members = await ref.watch( MembersByStatusController.provider(config).future, ); - return members.fold>>(.new(), (result, event) { - final groupKey = content.users[event.stateKey!] ?? content.usersDefault; + return members.fold>>(.new(), (result, event) { + final groupKey = creators?.contains(event.stateKey!) == true + ? null + : content.users[event.stateKey!] ?? content.usersDefault; return result.update( groupKey, @@ -43,7 +58,7 @@ class MembersGroupedController extends AsyncNotifier>> { static final provider = AsyncNotifierProvider.family< MembersGroupedController, - IMap>, + IMap>, MembersByStatusConfig >(MembersGroupedController.new); } diff --git a/lib/models/content/create.dart b/lib/models/content/create.dart index 6921c04..c534558 100644 --- a/lib/models/content/create.dart +++ b/lib/models/content/create.dart @@ -8,8 +8,6 @@ part "create.g.dart"; abstract class CreateContent extends Content with _$CreateContent { CreateContent._(); factory CreateContent({ - @JsonKey(name: "creator") String? creatorId, - @JsonKey(name: "additional_creators") @Default(IList.empty()) IList additionalCreatorIds, diff --git a/lib/widgets/member_list.dart b/lib/widgets/member_list.dart index f80f403..1f8fbce 100644 --- a/lib/widgets/member_list.dart +++ b/lib/widgets/member_list.dart @@ -75,10 +75,14 @@ class MemberList extends HookConsumerWidget { children: [ for (final MapEntry(key: powerLevel, value: members) in value.toEntryIList( - compare: (a, b) => (b?.key ?? double.negativeInfinity) - .compareTo(a?.key ?? double.negativeInfinity), + compare: (a, b) => (b?.key ?? double.infinity) + .compareTo(a?.key ?? double.infinity), )) ...[ - DividerText("Power Level $powerLevel"), + DividerText( + powerLevel == null + ? "Creators" + : "Power Level $powerLevel", + ), SegmentedListSection( children: members .map( -- 2.54.0 From bb6f0d4c3b344bbaa7a6af65797f4aeca93ce311 Mon Sep 17 00:00:00 2001 From: Henry-Hiles Date: Fri, 5 Jun 2026 14:53:26 -0400 Subject: [PATCH 3/7] add some more padding --- lib/widgets/member_list.dart | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/widgets/member_list.dart b/lib/widgets/member_list.dart index 1f8fbce..f95c991 100644 --- a/lib/widgets/member_list.dart +++ b/lib/widgets/member_list.dart @@ -78,10 +78,13 @@ class MemberList extends HookConsumerWidget { compare: (a, b) => (b?.key ?? double.infinity) .compareTo(a?.key ?? double.infinity), )) ...[ - DividerText( - powerLevel == null - ? "Creators" - : "Power Level $powerLevel", + Padding( + padding: EdgeInsets.symmetric(horizontal: 4), + child: DividerText( + powerLevel == null + ? "Creators" + : "Power Level $powerLevel", + ), ), SegmentedListSection( children: members @@ -123,6 +126,7 @@ class MemberList extends HookConsumerWidget { ) .toList(), ), + SizedBox(height: 4), ], ], ), -- 2.54.0 From f46dcbbb294cf455d2257ce5a1902ea0db0446da Mon Sep 17 00:00:00 2001 From: Henry-Hiles Date: Fri, 5 Jun 2026 15:40:20 -0400 Subject: [PATCH 4/7] use M3EToggleButtonGroup --- lib/widgets/member_list.dart | 194 +++++++++++++++++++---------------- pubspec.lock | 24 +++++ pubspec.yaml | 1 + 3 files changed, 133 insertions(+), 86 deletions(-) diff --git a/lib/widgets/member_list.dart b/lib/widgets/member_list.dart index f95c991..fbb3555 100644 --- a/lib/widgets/member_list.dart +++ b/lib/widgets/member_list.dart @@ -1,6 +1,8 @@ +import "package:fast_immutable_collections/fast_immutable_collections.dart"; import "package:flutter/material.dart"; import "package:flutter_hooks/flutter_hooks.dart"; import "package:hooks_riverpod/hooks_riverpod.dart"; +import "package:m3e_buttons/m3e_buttons.dart"; import "package:material_segmented_list/material_segmented_list.dart"; import "package:nexus/controllers/members_grouped_controller.dart"; import "package:nexus/helpers/extensions/get_localpart.dart"; @@ -20,6 +22,18 @@ class MemberList extends HookConsumerWidget { Widget build(BuildContext context, WidgetRef ref) { final status = useState(MembershipStatus.join); + final membersData = ref.watch( + MembersGroupedController.provider( + .new(roomId: roomId, status: status.value), + ), + ); + + final options = { + "Joined": MembershipStatus.join, + "Invited": MembershipStatus.invite, + "Banned": MembershipStatus.ban, + }; + return Drawer( shape: Border(), child: Column( @@ -38,99 +52,107 @@ class MemberList extends HookConsumerWidget { ), ], ), - Wrap( - alignment: .center, - spacing: 8, - runSpacing: 8, - children: [ - FilterChip( - label: Text("Joined"), - onSelected: (value) => status.value = .join, - selected: status.value == .join, - ), - FilterChip( - label: Text("Invited"), - onSelected: (value) => status.value = .invite, - selected: status.value == .invite, - ), - FilterChip( - label: Text("Banned"), - onSelected: (value) => status.value = .ban, - selected: status.value == .ban, - ), - ], + M3EToggleButtonGroup( + type: M3EButtonGroupType.connected, + selectedIndex: options.values.toIList().indexOf(status.value), + onSelectedIndexChanged: (index) => + status.value = options.values.elementAt(index ?? 0), + // overflow: M3EButtonGroupOverflow.menu, + actions: options + .mapTo( + (name, value) => M3EToggleButtonGroupAction( + checkedLabel: Text( + "$name${switch (membersData) { + AsyncData(:final value) || AsyncLoading(:final value?) => " (${value.values.expand((element) => element).length})", + _ => "", + }}", + ), + label: Text(name), + ), + ) + .toList(), ), - switch (ref.watch( - MembersGroupedController.provider( - .new(roomId: roomId, status: status.value), - ), - )) { + + switch (membersData) { AsyncError(:final error, :final stackTrace) => ErrorDialog( error, stackTrace, ), - AsyncData(:final value) || AsyncLoading(:final value?) => Expanded( - child: ListView( - padding: .all(12), - children: [ - for (final MapEntry(key: powerLevel, value: members) - in value.toEntryIList( - compare: (a, b) => (b?.key ?? double.infinity) - .compareTo(a?.key ?? double.infinity), - )) ...[ - Padding( - padding: EdgeInsets.symmetric(horizontal: 4), - child: DividerText( - powerLevel == null - ? "Creators" - : "Power Level $powerLevel", + AsyncData(:final value) || AsyncLoading(:final value?) => + value.isEmpty + ? Center( + child: Padding( + padding: .symmetric(vertical: 18), + child: Text( + "No ${options.keys.toIList()[options.values.toIList().indexOf(status.value)]} Members", + style: Theme.of(context).textTheme.headlineSmall, + ), + ), + ) + : Expanded( + child: ListView( + padding: .all(12), + children: [ + for (final MapEntry(key: powerLevel, value: members) + in value.toEntryIList( + compare: (a, b) => (b?.key ?? double.infinity) + .compareTo(a?.key ?? double.infinity), + )) ...[ + Padding( + padding: EdgeInsets.symmetric(horizontal: 4), + child: DividerText( + powerLevel == null + ? "Creators" + : "Power Level $powerLevel", + ), + ), + SegmentedListSection( + children: members + .map( + (member) => switch (member.content) { + MembershipContent( + :final avatarUrl, + :final displayName, + ) => + SegmentedListTile( + onTap: () {}, + // context.showUserPopover( + // member.content as MembershipContent, + // member.stateKey!, + // roomId: roomId, + // globalPosition: details.globalPosition, + // ), + title: Text( + displayName ?? + member.stateKey!.localpart, + overflow: .ellipsis, + style: .new( + color: member.stateKey!.colorHash, + fontWeight: .bold, + ), + ), + subtitle: Text( + member.stateKey!, + overflow: .ellipsis, + ), + leading: AvatarOrHash( + avatarUrl, + displayName ?? + member.sender.localpart, + ), + ), + _ => throw Exception( + "Member content was not MembershipContent", + ), + }, + ) + .toList(), + ), + SizedBox(height: 4), + ], + ], ), ), - SegmentedListSection( - children: members - .map( - (member) => switch (member.content) { - MembershipContent( - :final avatarUrl, - :final displayName, - ) => - SegmentedListTile( - onTap: () {}, - // context.showUserPopover( - // member.content as MembershipContent, - // member.stateKey!, - // roomId: roomId, - // globalPosition: details.globalPosition, - // ), - title: Text( - displayName ?? member.stateKey!.localpart, - overflow: .ellipsis, - style: .new( - color: member.stateKey!.colorHash, - fontWeight: .bold, - ), - ), - subtitle: Text( - member.stateKey!, - overflow: .ellipsis, - ), - leading: AvatarOrHash( - avatarUrl, - displayName ?? member.sender.localpart, - ), - ), - _ => throw Exception( - "Member content was not MembershipContent", - ), - }, - ) - .toList(), - ), - SizedBox(height: 4), - ], - ], - ), - ), AsyncLoading _ => Loading(), }, ], diff --git a/pubspec.lock b/pubspec.lock index dc5230a..385367d 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -299,6 +299,14 @@ packages: url: "https://github.com/Henry-Hiles/emoji_text_field" source: git version: "1.0.0" + equatable: + dependency: transitive + description: + name: equatable + sha256: "3e0141505477fd8ad55d6eb4e7776d3fe8430be8e497ccb1521370c3f21a3e2b" + url: "https://pub.dev" + source: hosted + version: "2.0.8" fake_async: dependency: transitive description: @@ -744,6 +752,14 @@ packages: url: "https://pub.dev" source: hosted version: "1.3.0" + m3e_buttons: + dependency: "direct main" + description: + name: m3e_buttons + sha256: "50cdf9ba30fb3ab529afafb0e837484549f8599f1f109ac07da50951febaace1" + url: "https://pub.dev" + source: hosted + version: "0.0.3" matcher: dependency: transitive description: @@ -856,6 +872,14 @@ packages: url: "https://pub.dev" source: hosted version: "2.0.0" + motor: + dependency: transitive + description: + name: motor + sha256: cbd49f21b00e568c2b1a55f134ed803614a107782f4fea7769693bca32940c58 + url: "https://pub.dev" + source: hosted + version: "1.1.0" native_toolchain_c: dependency: transitive description: diff --git a/pubspec.yaml b/pubspec.yaml index a2a2036..37b4ed4 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -65,6 +65,7 @@ dependencies: media_kit_libs_video: 1.0.7 measure_size: ^5.0.2 material_segmented_list: ^1.0.5 + m3e_buttons: ^0.0.3 dev_dependencies: build_runner: 2.15.0 -- 2.54.0 From 85dc5b1a4dbd0d3b78e46c5933fc88261f9dd2d9 Mon Sep 17 00:00:00 2001 From: istalri Date: Fri, 5 Jun 2026 17:28:53 -0400 Subject: [PATCH 5/7] better login flow Co-authored-by: Henry-Hiles --- lib/controllers/client_controller.dart | 4 +- lib/helpers/required_validator_helper.dart | 2 + lib/main.dart | 4 +- lib/pages/login_page.dart | 248 ++++++--------------- lib/pages/select_server_page.dart | 169 ++++++++++++++ lib/pages/verify_page.dart | 94 ++++---- lib/widgets/form_text_input.dart | 81 ------- lib/widgets/join_dialog.dart | 7 +- lib/widgets/room_chat.dart | 19 +- lib/widgets/user_popover.dart | 10 +- 10 files changed, 301 insertions(+), 337 deletions(-) create mode 100644 lib/helpers/required_validator_helper.dart create mode 100644 lib/pages/select_server_page.dart delete mode 100644 lib/widgets/form_text_input.dart diff --git a/lib/controllers/client_controller.dart b/lib/controllers/client_controller.dart index 5558beb..fb57735 100644 --- a/lib/controllers/client_controller.dart +++ b/lib/controllers/client_controller.dart @@ -261,12 +261,12 @@ class ClientController extends AsyncNotifier { } } - Future discoverHomeserver(Uri homeserver) async { + Future discoverHomeserver(Uri homeserver) async { try { final response = await _sendCommand("discover_homeserver", { "user_id": "@fake-user:${homeserver.host}", }); - return response["m.homeserver"]?["base_url"]; + return Uri.parse(response["m.homeserver"]?["base_url"]); } catch (error) { return null; } diff --git a/lib/helpers/required_validator_helper.dart b/lib/helpers/required_validator_helper.dart new file mode 100644 index 0000000..d243684 --- /dev/null +++ b/lib/helpers/required_validator_helper.dart @@ -0,0 +1,2 @@ +String? requiredValidator(String? value) => + value == null || value.isEmpty ? "This field is required" : null; diff --git a/lib/main.dart b/lib/main.dart index dcf7b67..dab4e16 100644 --- a/lib/main.dart +++ b/lib/main.dart @@ -11,7 +11,7 @@ import "package:nexus/controllers/shared_prefs_controller.dart"; import "package:nexus/helpers/extensions/better_when.dart"; import "package:nexus/helpers/extensions/scheme_to_theme.dart"; import "package:nexus/pages/chat_page.dart"; -import "package:nexus/pages/login_page.dart"; +import "package:nexus/pages/select_server_page.dart"; import "package:nexus/pages/verify_page.dart"; import "package:nexus/widgets/error_dialog.dart"; import "package:nexus/widgets/loading.dart"; @@ -124,7 +124,7 @@ class App extends StatelessWidget { } if (!clientState.isLoggedIn) { - return LoginPage(); + return SelectServerPage(); } else if (!clientState.isVerified) { return VerifyPage(); } else { diff --git a/lib/pages/login_page.dart b/lib/pages/login_page.dart index 58662f4..4969287 100644 --- a/lib/pages/login_page.dart +++ b/lib/pages/login_page.dart @@ -1,205 +1,95 @@ import "package:flutter/material.dart"; import "package:flutter_hooks/flutter_hooks.dart"; -import "package:flutter_svg/flutter_svg.dart"; import "package:hooks_riverpod/hooks_riverpod.dart"; import "package:nexus/controllers/client_controller.dart"; -import "package:nexus/helpers/launch_helper.dart"; -import "package:nexus/models/homeserver.dart"; import "package:nexus/widgets/appbar.dart"; -import "package:nexus/widgets/divider_text.dart"; -import "package:nexus/widgets/loading.dart"; +import "package:nexus/helpers/required_validator_helper.dart"; class LoginPage extends HookConsumerWidget { - const LoginPage({super.key}); + final Uri homeserver; + const LoginPage({super.key, required this.homeserver}); @override Widget build(BuildContext context, WidgetRef ref) { - final theme = Theme.of(context); final client = ref.watch(ClientController.provider.notifier); final isLoading = useState(false); - final homeserver = useState(null); - - final launch = ref.watch(LaunchHelper.provider).launchUrl; - - Future setHomeserver(Uri? newHomeserver) async { - isLoading.value = true; - - homeserver.value = newHomeserver == null - ? null - : await client.discoverHomeserver( - newHomeserver.hasScheme - ? newHomeserver - : Uri.https(newHomeserver.path), - ); - - if (homeserver.value == null && context.mounted) { - ScaffoldMessenger.of(context).showSnackBar( - .new( - content: Text( - "Homeserver verification failed. Is your homeserver down?", - style: TextStyle(color: theme.colorScheme.onErrorContainer), - ), - backgroundColor: theme.colorScheme.errorContainer, - ), - ); - } - isLoading.value = false; - } - - final homeserverUrl = useTextEditingController(); final username = useTextEditingController(); final password = useTextEditingController(); + final inputError = useState(null); + final formKey = useRef(GlobalKey()); + + Future tryLogin() async { + isLoading.value = true; + + try { + if (formKey.value.currentState?.validate() != true) return; + + final error = await client.login( + .new( + username: username.text, + password: password.text, + homeserverUrl: homeserver.origin, + ), + ); + + if (error != null) { + inputError.value = error; + isLoading.value = false; + } else { + if (context.mounted) Navigator.of(context).pop(); + } + } finally { + isLoading.value = false; + } + } + return Scaffold( - appBar: Appbar(), - body: Center( - child: ConstrainedBox( - constraints: .new(maxWidth: 600), - child: ListView( - padding: .symmetric(horizontal: 16, vertical: 64), + appBar: Appbar( + leading: IconButton( + icon: Icon(Icons.arrow_back), + onPressed: Navigator.of(context).pop, + ), + ), + body: AlertDialog( + title: Text("Login to ${homeserver.host}"), + content: Form( + key: formKey.value, + child: Column( + mainAxisSize: .min, + crossAxisAlignment: .start, children: [ - Row( - children: [ - SvgPicture.asset("assets/icon.svg", width: 128), - SizedBox(width: 12), - Expanded( - child: Column( - crossAxisAlignment: .start, - children: [ - Text("Nexus", style: theme.textTheme.displayMedium), - Text( - "A Simple Matrix Client", - style: theme.textTheme.headlineMedium, - overflow: .ellipsis, - ), - ], - ), - ), - ], + TextFormField( + autofocus: true, + textInputAction: .next, + autovalidateMode: .onUserInteraction, + validator: requiredValidator, + decoration: .new(label: Text("Username")), + controller: username, ), - Padding(padding: .symmetric(vertical: 12), child: Divider()), - - DividerText("Enter a homeserver domain:"), - Row( - spacing: 8, - children: [ - Expanded( - child: TextField( - controller: homeserverUrl, - decoration: .new( - labelText: "Homeserver URL (e.g. matrix.org)", - ), - ), - ), - IconButton.filled( - tooltip: "Confirm homeserver choice", - onPressed: isLoading.value - ? null - : () => setHomeserver(.tryParse(homeserverUrl.text)), - icon: Icon(Icons.check), - ), - ], + SizedBox(height: 12), + TextFormField( + textInputAction: .done, + decoration: .new( + label: Text("Password"), + errorText: inputError.value, + errorMaxLines: 5, + ), + autovalidateMode: .onUserInteraction, + validator: requiredValidator, + controller: password, + obscureText: true, ), - - DividerText("Or, choose from some popular homeservers:"), - ...([ - .new( - name: "Matrix.org", - description: - "The Matrix.org Foundation offers the matrix.org homeserver as an easy entry point for anyone wanting to try out Matrix.", - url: .https("matrix.org"), - iconUrl: - "https://raw.githubusercontent.com/element-hq/logos/refs/heads/master/matrix/matrix-favicon${Theme.brightnessOf(context) == Brightness.dark ? "-white" : ""}.png", - ), - .new( - name: "Federated Nexus", - description: - "Federated Nexus is a community resource hosting multiple FOSS (especially federated) services, including Matrix and Forgejo. By the same developers who made Nexus client.", - url: .https("federated.nexus"), - iconUrl: "https://federated.nexus/images/icon.png", - ), - .new( - name: "Unredacted", - description: - "Unredacted is a 501(c)(3) non-profit organization that builds Internet infrastructure and services to help people evade censorship and protect their right to privacy.", - url: .https("unredacted.org", "services/si/matrix"), - iconUrl: "https://unredacted.org/favicon.ico", - ), - ].map( - (homeserver) => Card( - child: ListTile( - title: Text(homeserver.name), - leading: Image.network( - homeserver.iconUrl, - errorBuilder: (_, _, _) => SizedBox.shrink(), - height: 32, - ), - subtitle: Text(homeserver.description), - onTap: isLoading.value - ? null - : () => setHomeserver(homeserver.url), - trailing: IconButton( - tooltip: "Launch homeserver info page", - onPressed: () => launch(homeserver.url), - icon: Icon(Icons.info_outline), - ), - ), - ), - )), - SizedBox(height: 8), - TextButton( - onPressed: () => launch(.https("servers.joinmatrix.org")), - child: Text("See more homeservers..."), - ), - if (isLoading.value) - Padding(padding: .only(top: 32), child: Loading()) - else if (homeserver.value != null) ...[ - DividerText("Then, sign in:"), - SizedBox(height: 4), - TextField( - decoration: .new(label: Text("Username")), - controller: username, - ), - SizedBox(height: 12), - TextField( - decoration: .new(label: Text("Password")), - controller: password, - obscureText: true, - ), - SizedBox(height: 12), - ElevatedButton( - onPressed: () async { - isLoading.value = true; - final error = await client.login( - .new( - username: username.text, - password: password.text, - homeserverUrl: homeserver.value!, - ), - ); - - if (error != null && context.mounted) { - ScaffoldMessenger.of(context).showSnackBar( - .new( - content: Text( - "Login failed. Is your password right?\nError: $error", - style: .new( - color: theme.colorScheme.onErrorContainer, - ), - ), - backgroundColor: theme.colorScheme.errorContainer, - ), - ); - isLoading.value = false; - } - }, - child: Text("Sign In"), - ), - ], ], ), ), + actions: [ + TextButton( + onPressed: isLoading.value ? null : tryLogin, + child: Text("Sign In"), + ), + ], ), ); } diff --git a/lib/pages/select_server_page.dart b/lib/pages/select_server_page.dart new file mode 100644 index 0000000..f0e7dff --- /dev/null +++ b/lib/pages/select_server_page.dart @@ -0,0 +1,169 @@ +import "package:flutter/material.dart"; +import "package:flutter_hooks/flutter_hooks.dart"; +import "package:flutter_svg/flutter_svg.dart"; +import "package:hooks_riverpod/hooks_riverpod.dart"; +import "package:nexus/controllers/client_controller.dart"; +import "package:nexus/helpers/launch_helper.dart"; +import "package:nexus/models/homeserver.dart"; +import "package:nexus/pages/login_page.dart"; +import "package:nexus/widgets/appbar.dart"; +import "package:nexus/widgets/divider_text.dart"; + +class SelectServerPage extends HookConsumerWidget { + const SelectServerPage({super.key}); + + @override + Widget build(BuildContext context, WidgetRef ref) { + final theme = Theme.of(context); + + final launch = ref.watch(LaunchHelper.provider).launchUrl; + + final isLoading = useState(false); + final homeserverUrl = useTextEditingController(); + + Future setHomeserver(Uri? newHomeserver) async { + isLoading.value = true; + + try { + if (newHomeserver?.hasScheme == false) { + newHomeserver = Uri.https(newHomeserver!.path); + } + + final newUrl = newHomeserver == null + ? null + : await ref + .watch(ClientController.provider.notifier) + .discoverHomeserver(newHomeserver); + + if (context.mounted) { + if (newUrl == null) { + ScaffoldMessenger.of(context).showSnackBar( + SnackBar( + content: Text( + "Homeserver verification failed. Is your homeserver down?", + style: .new(color: theme.colorScheme.onErrorContainer), + ), + backgroundColor: theme.colorScheme.errorContainer, + ), + ); + } else { + await Navigator.of(context).push( + MaterialPageRoute(builder: (_) => LoginPage(homeserver: newUrl)), + ); + } + } + } finally { + isLoading.value = false; + } + } + + return Scaffold( + appBar: Appbar(), + body: Center( + child: ConstrainedBox( + constraints: .new(maxWidth: 600), + child: ListView( + children: [ + Row( + children: [ + SvgPicture.asset("assets/icon.svg", width: 128), + SizedBox(width: 12), + Expanded( + child: Column( + crossAxisAlignment: .start, + children: [ + Text("Nexus", style: theme.textTheme.displayMedium), + Text( + "A Simple Matrix Client", + style: theme.textTheme.headlineMedium, + overflow: .ellipsis, + ), + ], + ), + ), + ], + ), + Padding(padding: .symmetric(vertical: 12), child: Divider()), + DividerText("Enter a homeserver domain:"), + Row( + spacing: 8, + children: [ + Expanded( + child: TextField( + textInputAction: .done, + autofocus: true, + onSubmitted: (text) => setHomeserver(.tryParse(text)), + controller: homeserverUrl, + decoration: .new( + labelText: "Homeserver URL", + hintText: "matrix.org", + ), + ), + ), + IconButton.filled( + tooltip: "Confirm homeserver choice", + onPressed: isLoading.value + ? null + : () => setHomeserver(.tryParse(homeserverUrl.text)), + icon: Icon(Icons.check), + ), + ], + ), + DividerText("Or, choose from some popular homeservers:"), + ...([ + .new( + name: "Matrix.org", + description: + "The Matrix.org Foundation offers the matrix.org homeserver as an easy entry point for anyone wanting to try out Matrix.", + url: .https("matrix.org"), + iconUrl: + "https://raw.githubusercontent.com/element-hq/logos/refs/heads/master/matrix/matrix-favicon${Theme.brightnessOf(context) == Brightness.dark ? "-white" : ""}.png", + ), + .new( + name: "Federated Nexus", + description: + "Federated Nexus is a community resource hosting multiple FOSS (especially federated) services, including Matrix and Forgejo. By the same developers who made Nexus client.", + url: .https("federated.nexus"), + iconUrl: "https://federated.nexus/images/icon.png", + ), + .new( + name: "Unredacted", + description: + "Unredacted is a 501(c)(3) non-profit organization that builds Internet infrastructure and services to help people evade censorship and protect their right to privacy.", + url: .https("unredacted.org", "services/si/matrix"), + iconUrl: "https://unredacted.org/favicon.ico", + ), + ].map( + (homeserver) => Card( + child: ListTile( + enabled: !isLoading.value, + title: Text(homeserver.name), + leading: Image.network( + homeserver.iconUrl, + errorBuilder: (_, _, _) => SizedBox.shrink(), + height: 32, + ), + subtitle: Text(homeserver.description), + onTap: isLoading.value + ? null + : () => setHomeserver(homeserver.url), + trailing: IconButton( + tooltip: "Launch homeserver info page", + onPressed: () => launch(homeserver.url), + icon: Icon(Icons.info_outline), + ), + ), + ), + )), + + TextButton( + onPressed: () => launch(.https("servers.joinmatrix.org")), + child: Text("See more homeservers..."), + ), + ], + ), + ), + ), + ); + } +} diff --git a/lib/pages/verify_page.dart b/lib/pages/verify_page.dart index 0469fa4..a2089e3 100644 --- a/lib/pages/verify_page.dart +++ b/lib/pages/verify_page.dart @@ -3,7 +3,7 @@ import "package:flutter_hooks/flutter_hooks.dart"; import "package:hooks_riverpod/hooks_riverpod.dart"; import "package:nexus/controllers/client_controller.dart"; import "package:nexus/widgets/appbar.dart"; -import "package:nexus/widgets/form_text_input.dart"; +import "package:nexus/helpers/required_validator_helper.dart"; class VerifyPage extends HookConsumerWidget { const VerifyPage({super.key}); @@ -11,70 +11,56 @@ class VerifyPage extends HookConsumerWidget { @override Widget build(BuildContext context, WidgetRef ref) { final passphraseController = useTextEditingController(); - final isVerifying = useState(false); + final isLoading = useState(false); + final inputError = useState(null); + final formKey = useRef(GlobalKey()); + return Scaffold( appBar: Appbar(), body: AlertDialog( title: Text("Verify"), - content: Column( - mainAxisSize: .min, - crossAxisAlignment: .start, - children: [ - Text( - "Enter your recovery key or passphrase below to unlock encrypted events.\nYour passphrase is usually not the same as your password.", - ), - SizedBox(height: 12), - FormTextInput( - required: false, - autofocus: true, - capitalize: true, - controller: passphraseController, - obscure: true, - title: "Recovery Key or Passphrase", - ), - ], + content: Form( + key: formKey.value, + child: Column( + mainAxisSize: .min, + crossAxisAlignment: .start, + children: [ + Text( + "Enter your recovery key or passphrase below to unlock encrypted events.\nYour passphrase is usually not the same as your password.", + ), + SizedBox(height: 12), + TextFormField( + autofocus: true, + controller: passphraseController, + textInputAction: .done, + autovalidateMode: .onUserInteraction, + validator: requiredValidator, + obscureText: true, + decoration: .new( + label: Text("Recovery Key or Passphrase"), + errorText: inputError.value, + ), + ), + ], + ), ), actions: [ TextButton( - onPressed: isVerifying.value + onPressed: isLoading.value ? null : () async { - final scaffoldMessenger = ScaffoldMessenger.of(context); - final snackbar = scaffoldMessenger.showSnackBar( - .new( - content: Text( - "Attempting to verify with recovery key...", - ), - duration: .new(days: 999), - ), - ); + isLoading.value = true; - isVerifying.value = true; - - final error = await ref - .watch(ClientController.provider.notifier) - .verify(passphraseController.text); - - snackbar.close(); - if (error != null) { - isVerifying.value = false; - if (context.mounted) { - scaffoldMessenger.showSnackBar( - .new( - backgroundColor: Theme.of( - context, - ).colorScheme.errorContainer, - content: Text( - "Verification failed. Is your passphrase correct?\nError: $error", - style: .new( - color: Theme.of( - context, - ).colorScheme.onErrorContainer, - ), - ), - ), - ); + try { + if (formKey.value.currentState?.validate() != true) { + return; } + + inputError.value = await ref + .watch(ClientController.provider.notifier) + .verify(passphraseController.text); + } finally { + isLoading.value = false; } }, child: Text("Verify"), diff --git a/lib/widgets/form_text_input.dart b/lib/widgets/form_text_input.dart deleted file mode 100644 index 8b48883..0000000 --- a/lib/widgets/form_text_input.dart +++ /dev/null @@ -1,81 +0,0 @@ -import "package:flutter/material.dart"; -import "package:flutter/services.dart"; - -class FormTextInput extends StatelessWidget { - final List extraValidators; - final TextEditingController? controller; - final TextInputType keyboardType; - final String? initialValue; - final bool readOnly; - final bool obscure; - final String? title; - final int? minLines; - final int? maxLength; - final bool outlined; - final int? maxLines; - final bool capitalize; - final bool required; - final bool autocorrect; - final void Function()? onTap; - final Widget? trailing; - final InputBorder? border; - final List? formatters; - final bool autofocus; - - const FormTextInput({ - super.key, - this.border, - this.controller, - this.autofocus = false, - this.title, - this.obscure = false, - this.readOnly = false, - this.extraValidators = const [], - this.keyboardType = TextInputType.text, - this.initialValue, - this.minLines, - this.capitalize = false, - this.maxLength, - this.formatters, - this.maxLines = 1, - this.outlined = true, - this.trailing, - this.onTap, - this.autocorrect = true, - this.required = true, - }); - - @override - Widget build(BuildContext context) => TextFormField( - autofocus: autofocus, - controller: controller, - keyboardType: keyboardType, - readOnly: readOnly, - minLines: minLines, - maxLines: maxLines, - maxLength: maxLength, - inputFormatters: formatters, - textCapitalization: capitalize ? .sentences : .none, - initialValue: initialValue, - autocorrect: autocorrect, - obscureText: obscure, - onTap: onTap, - decoration: .new( - labelText: title, - border: border ?? (outlined ? null : const UnderlineInputBorder()), - suffixIcon: trailing, - ), - validator: (value) { - if ((value?.isEmpty ?? true) && required) { - return "This field is required"; - } - - for (final validator in extraValidators) { - final reason = validator(value!); - if (reason != null) return reason; - } - - return null; - }, - ); -} diff --git a/lib/widgets/join_dialog.dart b/lib/widgets/join_dialog.dart index e20ab2a..d265595 100644 --- a/lib/widgets/join_dialog.dart +++ b/lib/widgets/join_dialog.dart @@ -6,7 +6,6 @@ import "package:nexus/controllers/client_controller.dart"; import "package:nexus/controllers/key_controller.dart"; import "package:nexus/controllers/spaces_controller.dart"; import "package:nexus/helpers/extensions/link_to_mention.dart"; -import "package:nexus/widgets/form_text_input.dart"; class JoinDialog extends HookWidget { final WidgetRef ref; @@ -23,11 +22,9 @@ class JoinDialog extends HookWidget { children: [ Text("Enter the room alias, Matrix URI, or Matrix.to link."), SizedBox(height: 12), - FormTextInput( - required: false, - capitalize: true, + TextField( controller: roomAlias, - title: "#room:server", + decoration: .new(hintText: "#room:server"), ), ], ), diff --git a/lib/widgets/room_chat.dart b/lib/widgets/room_chat.dart index 9e3d281..beab387 100644 --- a/lib/widgets/room_chat.dart +++ b/lib/widgets/room_chat.dart @@ -22,7 +22,6 @@ import "package:nexus/widgets/member_list.dart"; import "package:nexus/widgets/room_appbar.dart"; import "package:nexus/widgets/flash_wrapper.dart"; import "package:nexus/widgets/error_dialog.dart"; -import "package:nexus/widgets/form_text_input.dart"; import "package:nexus/main.dart"; import "package:nexus/widgets/loading.dart"; import "package:super_sliver_list/super_sliver_list.dart"; @@ -288,11 +287,12 @@ class RoomChat extends HookConsumerWidget { "Are you sure you want to delete this message? This can not be reversed.", ), SizedBox(height: 12), - FormTextInput( - required: false, - capitalize: true, + TextField( controller: deleteReasonController, - title: "Reason for deletion (optional)", + textCapitalization: .sentences, + decoration: .new( + labelText: "Reason for deletion (optional)", + ), ), ], ), @@ -340,11 +340,12 @@ class RoomChat extends HookConsumerWidget { ), SizedBox(height: 12), - FormTextInput( - required: false, - capitalize: true, + TextField( controller: reasonController, - title: "Reason for report (optional)", + textCapitalization: .sentences, + decoration: .new( + labelText: "Reason for report (optional)", + ), ), ], ), diff --git a/lib/widgets/user_popover.dart b/lib/widgets/user_popover.dart index 65fff87..97d88c4 100644 --- a/lib/widgets/user_popover.dart +++ b/lib/widgets/user_popover.dart @@ -14,7 +14,6 @@ import "package:nexus/models/requests/membership_action.dart"; import "package:nexus/widgets/avatar_or_hash.dart"; import "package:nexus/main.dart"; import "package:nexus/widgets/expandable_image.dart"; -import "package:nexus/widgets/form_text_input.dart"; class UserPopover extends ConsumerWidget { final MembershipContent member; @@ -41,11 +40,12 @@ class UserPopover extends ConsumerWidget { children: [ Text("Are you sure you want to ${action.name} $userId?"), SizedBox(height: 12), - FormTextInput( - required: false, - capitalize: true, + TextField( + textCapitalization: .sentences, controller: actionReasonController, - title: "Reason for ${action.name} (optional)", + decoration: .new( + labelText: "Reason for ${action.name} (optional)", + ), ), ], ), -- 2.54.0 From 5cc4741e4b85e9208a4d4af1442050456ab82e54 Mon Sep 17 00:00:00 2001 From: Henry-Hiles Date: Fri, 5 Jun 2026 18:10:18 -0400 Subject: [PATCH 6/7] add null check in room chat controller --- lib/controllers/room_chat_controller.dart | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/controllers/room_chat_controller.dart b/lib/controllers/room_chat_controller.dart index 84ac7b0..7cd79b8 100644 --- a/lib/controllers/room_chat_controller.dart +++ b/lib/controllers/room_chat_controller.dart @@ -24,9 +24,8 @@ class RoomChatController extends AsyncNotifier> { final room = ref.watch( RoomsController.provider.select((rooms) => rooms[roomId]), ); - if (room == null) return .new(); - if (!room.hasFetchedState) { + if (!room!.hasFetchedState) { final state = await client.getRoomState(.new(roomId: roomId)); await ref.read(RoomsController.provider.notifier).addState(roomId, state); -- 2.54.0 From b6c0dc0617f86d004abc0310f21f7af158b85350 Mon Sep 17 00:00:00 2001 From: Henry-Hiles Date: Fri, 5 Jun 2026 18:33:16 -0400 Subject: [PATCH 7/7] better handle when room is null --- lib/controllers/room_chat_controller.dart | 10 +++-- lib/widgets/room_appbar.dart | 45 ++++++++++++----------- lib/widgets/room_chat.dart | 20 +++++----- lib/widgets/sidebar.dart | 4 +- 4 files changed, 42 insertions(+), 37 deletions(-) diff --git a/lib/controllers/room_chat_controller.dart b/lib/controllers/room_chat_controller.dart index 7cd79b8..07b3650 100644 --- a/lib/controllers/room_chat_controller.dart +++ b/lib/controllers/room_chat_controller.dart @@ -14,18 +14,20 @@ import "package:nexus/models/relation_type.dart"; import "package:nexus/models/requests/send_message_request.dart"; import "package:nexus/models/room.dart"; -class RoomChatController extends AsyncNotifier> { +class RoomChatController extends AsyncNotifier?> { final String roomId; RoomChatController(this.roomId); @override - Future> build() async { + Future?> build() async { final client = ref.watch(ClientController.provider.notifier); final room = ref.watch( RoomsController.provider.select((rooms) => rooms[roomId]), ); - if (!room!.hasFetchedState) { + if (room == null) return null; + + if (!room.hasFetchedState) { final state = await client.getRoomState(.new(roomId: roomId)); await ref.read(RoomsController.provider.notifier).addState(roomId, state); @@ -214,7 +216,7 @@ class RoomChatController extends AsyncNotifier> { } static final provider = AsyncNotifierProvider.family - .autoDispose, String>( + .autoDispose?, String>( RoomChatController.new, ); } diff --git a/lib/widgets/room_appbar.dart b/lib/widgets/room_appbar.dart index d16c2df..e1d5708 100644 --- a/lib/widgets/room_appbar.dart +++ b/lib/widgets/room_appbar.dart @@ -1,4 +1,3 @@ -import "package:fast_immutable_collections/fast_immutable_collections.dart"; import "package:flutter/material.dart"; import "package:hooks_riverpod/hooks_riverpod.dart"; import "package:nexus/controllers/rooms_controller.dart"; @@ -93,13 +92,15 @@ class RoomAppbar extends ConsumerWidget implements PreferredSizeWidget { ), ), ), - leading: isDesktop && room != null - ? AvatarOrHash( - room.metadata?.avatar, - room.metadata?.name ?? "Unnamed Room", - height: 24, - fallback: Icon(Icons.numbers), - ) + leading: isDesktop + ? room == null + ? null + : AvatarOrHash( + room.metadata?.avatar, + room.metadata?.name ?? "Unnamed Room", + height: 24, + fallback: Icon(Icons.numbers), + ) : DrawerButton(onPressed: () => onOpenDrawer(context)), scrolledUnderElevation: 0, title: room == null @@ -123,19 +124,21 @@ class RoomAppbar extends ConsumerWidget implements PreferredSizeWidget { ), ], ), - actions: [ - IconButton( - onPressed: null, - icon: Icon(Icons.push_pin), - tooltip: "Open pinned messages", - ), - IconButton( - onPressed: () => onOpenMemberList?.call(context), - tooltip: "Open member list", - icon: Icon(Icons.people), - ), - if (room != null) RoomMenu(room), - ].toIList(), + actions: room == null + ? .new() + : .new([ + IconButton( + onPressed: null, + icon: Icon(Icons.push_pin), + tooltip: "Open pinned messages", + ), + IconButton( + onPressed: () => onOpenMemberList?.call(context), + tooltip: "Open member list", + icon: Icon(Icons.people), + ), + RoomMenu(room), + ]), ); } } diff --git a/lib/widgets/room_chat.dart b/lib/widgets/room_chat.dart index beab387..2ab2cf7 100644 --- a/lib/widgets/room_chat.dart +++ b/lib/widgets/room_chat.dart @@ -50,6 +50,12 @@ class RoomChat extends HookConsumerWidget { final userId = ref.watch(ClientStateController.provider)?.userId; final theme = Theme.of(context); + final nothing = Center( + child: Text( + "Nothing to see here...", + style: theme.textTheme.headlineMedium, + ), + ); if (userId == null || this.roomId == null) { return Scaffold( appBar: RoomAppbar( @@ -58,12 +64,7 @@ class RoomChat extends HookConsumerWidget { onOpenDrawer: (_) => Scaffold.of(context).openDrawer(), onOpenMemberList: null, ), - body: Center( - child: Text( - "Nothing to see here...", - style: theme.textTheme.headlineMedium, - ), - ), + body: nothing, ); } @@ -81,7 +82,7 @@ class RoomChat extends HookConsumerWidget { final topEventBeforeLoad = useState(null); Future loadOlder() async { - if (controllerData case AsyncData(:final value)) { + if (controllerData case AsyncData(:final value?)) { topEventBeforeLoad.value = value.firstOrNull?.eventId; await notifier.loadOlder(); } @@ -105,7 +106,7 @@ class RoomChat extends HookConsumerWidget { useEffect(() { if (controllerData case AsyncData( - :final value, + :final value?, ) when scrollController.hasClients) { if (topEventBeforeLoad.value != null) { WidgetsBinding.instance.addPostFrameCallback((_) { @@ -401,7 +402,7 @@ class RoomChat extends HookConsumerWidget { child: Padding( padding: .symmetric(horizontal: 12), child: switch (controllerData) { - AsyncData(:final value) || + AsyncData(:final value?) || AsyncLoading(:final value?) => CustomScrollView( controller: scrollController, slivers: [ @@ -467,6 +468,7 @@ class RoomChat extends HookConsumerWidget { ), ], ), + AsyncData() => nothing, AsyncLoading() => Loading(), AsyncError(:final error, :final stackTrace) => ErrorDialog(error, stackTrace), diff --git a/lib/widgets/sidebar.dart b/lib/widgets/sidebar.dart index 3217173..dcbb671 100644 --- a/lib/widgets/sidebar.dart +++ b/lib/widgets/sidebar.dart @@ -39,9 +39,7 @@ class Sidebar extends HookConsumerWidget { (room) => room.metadata?.id == selectedRoomId, ); final selectedRoomIndex = indexOfSelectedRoom == -1 - ? selectedSpace.children.isEmpty - ? null - : 0 + ? null : indexOfSelectedRoom; return Drawer( -- 2.54.0