mirrors/qmk_userspace
1
0
Fork 1
mirror of https://github.com/qmk/qmk_userspace.git synced 2026-04-22 11:30:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove same-hand timing heuristic from get_chordal_hold

Browse source 
Mod-tap keys now always resolve as hold when another key is pressed
while they're down. The 150ms timing hack made same-hand shortcuts
like CMD+A unreliable.

https://claude.ai/code/session_01Q6jUPkVNbXkBqPgkmLWsTK
This commit is contained in:
Claude 2026-04-14 22:16:21 +00:00
commit 67ea58956e
No known key found for this signature in database
1 changed files with 3 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

31
users/timfee/timfee.c
View file

@ -25,36 +25,11 @@ const char chordal_hold_layout[MATRIX_ROWS][MATRIX_COLS] PROGMEM = {
{ 0, 0, 0, 'R', 'R', 'R', 0 }, // row 7: right thumb
};
// ── Chordal Hold per-key override ──
// Layer-tap keys always resolve as hold so the layer activates for
// same-hand keys. Cross-hand mod-tap chords always resolve as hold.
// Same-hand mod-tap chords use a timing heuristic: if the other key
// arrives within 150 ms of the tap-hold key press it is a fast typing
// roll (tap); otherwise the user is deliberately holding a modifier
// for a shortcut like Cmd+V or Cmd+Shift+V (hold).
#define CHORDAL_SAME_HAND_MS 150
bool get_chordal_hold(uint16_t tap_hold_keycode, keyrecord_t *tap_hold_record,
uint16_t other_keycode, keyrecord_t *other_record) {
// Layer-tap: always hold (layers need same-hand access).
if (IS_QK_LAYER_TAP(tap_hold_keycode)) {
return true;
}
// Cross-hand: always hold (standard chordal behaviour).
if (get_chordal_hold_default(tap_hold_record, other_record)) {
return true;
}
// Same-hand mod-tap: timing decides tap vs hold.
if (IS_QK_MOD_TAP(tap_hold_keycode)) {
uint16_t elapsed =
other_record->event.time - tap_hold_record->event.time;
return elapsed >= CHORDAL_SAME_HAND_MS;
}
// Any other same-hand combo: tap.
return false;
if (IS_QK_LAYER_TAP(tap_hold_keycode)) return true;
if (IS_QK_MOD_TAP(tap_hold_keycode)) return true;
return get_chordal_hold_default(tap_hold_record, other_record);
}
// ── Combos (matching Vial config) ──