From 6a499d0ae99059eb8060657b4a1da551289ef195 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 12 Apr 2026 21:35:08 +0000 Subject: [PATCH] Revert code review suggestions that broke Vial combo introspection The Keebart Vial fork requires combos to be in the same compilation unit as the keymap (via #include KEYMAP_C introspection). The Copilot code review suggested removing #include "timfee.c" from keymap.c and re-adding SRC += timfee.c to rules.mk, which broke this mechanism. Restore the working state: include timfee.c directly in keymap.c and remove the separate SRC compilation. Agent-Logs-Url: https://github.com/timfee/qmk_userspace/sessions/6c6892d3-5ab0-46b6-8c6c-7a1490274312 Co-authored-by: timfee <3246342+timfee@users.noreply.github.com> --- keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c | 1 + users/timfee/rules.mk | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c b/keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c index 0675d293..cd4eb526 100644 --- a/keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c +++ b/keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c @@ -1,4 +1,5 @@ #include "timfee.h" +#include "timfee.c" const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { diff --git a/users/timfee/rules.mk b/users/timfee/rules.mk index 5f0350ce..ab1e4381 100644 --- a/users/timfee/rules.mk +++ b/users/timfee/rules.mk @@ -1,2 +1 @@ COMBO_ENABLE = yes -SRC += timfee.c