From b6d7632097a3b8c20d073d4ed7498590398e339c Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 31 Mar 2026 21:20:38 +0000 Subject: [PATCH] Fix build: include user code in keymap for combo introspection The Keebart Vial fork's keymap_introspection.c does #include KEYMAP_C to discover combos at compile time. Combos defined in a separately compiled file (via SRC += timfee.c) aren't visible to introspection, causing 'key_combos undeclared' errors. Fix by #include-ing timfee.c from keymap.c so combos are visible to the introspection system. Remove SRC += timfee.c since the file is now included directly. Restore COMBO_COUNT required by this fork. Verified: builds successfully locally producing .uf2 firmware. https://claude.ai/code/session_01G7xpKdeQFVBvr4iCzxrcTU --- keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c | 1 + users/timfee/config.h | 1 + users/timfee/rules.mk | 1 - users/timfee/timfee.c | 2 +- 4 files changed, 3 insertions(+), 2 deletions(-) diff --git a/keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c b/keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c index 0675d293..cd4eb526 100644 --- a/keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c +++ b/keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c @@ -1,4 +1,5 @@ #include "timfee.h" +#include "timfee.c" const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { diff --git a/users/timfee/config.h b/users/timfee/config.h index a3437c5e..5ce6c48c 100644 --- a/users/timfee/config.h +++ b/users/timfee/config.h @@ -11,5 +11,6 @@ #define RETRO_TAPPING_PER_KEY // ── Combos ── +#define COMBO_COUNT 8 #define COMBO_TERM 40 #define COMBO_ONLY_FROM_LAYER 0 diff --git a/users/timfee/rules.mk b/users/timfee/rules.mk index 5e04c048..ab1e4381 100644 --- a/users/timfee/rules.mk +++ b/users/timfee/rules.mk @@ -1,2 +1 @@ -SRC += timfee.c COMBO_ENABLE = yes diff --git a/users/timfee/timfee.c b/users/timfee/timfee.c index 3aff75e8..19863955 100644 --- a/users/timfee/timfee.c +++ b/users/timfee/timfee.c @@ -13,7 +13,7 @@ const uint16_t PROGMEM rbkt_combo[] = {KC_N, KC_M, COMBO_END}; const uint16_t PROGMEM pipe_combo[] = {Z_L2, KC_X, COMBO_END}; const uint16_t PROGMEM bslh_combo[] = {SL_L1, KC_QUOT, COMBO_END}; -combo_t key_combos[] = { +combo_t key_combos[COMBO_COUNT] = { COMBO(lparen_combo, KC_LPRN), COMBO(rparen_combo, KC_RPRN), COMBO(lbrace_combo, KC_LCBR),