- Toronto, Canada
- https://henryhiles.com
-
Joined on
2025-03-25 -
-
Seems fine other than these. I'd also appreciate if you could fix the merge conflicts.
Yeah, that should work great. I have it set to format on save.
Also, you should use Navigator.of(context).push, and await it.
These focusnodes shouldnt be needed. Perhaps we just need a Form()
Please keep width as default always, and only override the border at all if hasError is true. Also, does both focusedBorder and enabledBorder need to be set?
bad formatting here. make sure you format your code :)
Uh, no it's not. The "safe"/normal way is to set autofocus on the text field.
you changed this to have two spaces between the ) and {, not sure why
Might be nice to do that Uri.parse in client.discoverHomeserver, and have that return a Uri.
This mostly looks good, just a couple things I think should be done a different way.
Lets take in final Uri homeserver as an argument here, instead of using ClientStateController.
I don't think this logic needs to be changed this much. If you can keep the previous logic, but instead show ServerSelectPage instead of login, we can take a different approach to push the login.
Given this won't be persistent anyways, I think we can go for a simpler approach and not touch client state controller.
I'd appreciate if you didn't commit these changes.