add a global toggle to hide membership events #142

Merged
Henry-Hiles merged 2 commits from seres/nexus:feat/hide_membership_events into main 2026-10-20 18:15:02 -04:00
Contributor

fixes #141

fixes #141
Henry-Hiles left a comment

other than some small nitpicks this looks good :)

other than some small nitpicks this looks good :)
@ -81,0 +83,4 @@
.watch(SettingsController.provider)
.maybeWhen(
orElse: () => false,
data: (settings) => settings.hideMembershipEvents ? true : false,
Owner

This ternary seems useless :)

You could remove it.

This ternary seems useless :) You could remove it.
Henry-Hiles marked this conversation as resolved
@ -81,0 +86,4 @@
data: (settings) => settings.hideMembershipEvents ? true : false,
));
if (event.type == "m.room.member" && hideMembershipEvents) {
Owner

Better check the type of content instead of a string, e.g. event.content is MembershipContent

Better check the type of content instead of a string, e.g. `event.content is MembershipContent`
Henry-Hiles marked this conversation as resolved
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Nexus/nexus!142
No description provided.