add a global toggle to hide membership events #142
No reviewers
Labels
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Nexus/nexus!142
Loading…
Reference in a new issue
No description provided.
Delete branch "seres/nexus:feat/hide_membership_events"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fixes #141
other than some small nitpicks this looks good :)
@ -81,0 +83,4 @@.watch(SettingsController.provider).maybeWhen(orElse: () => false,data: (settings) => settings.hideMembershipEvents ? true : false,This ternary seems useless :)
You could remove it.
@ -81,0 +86,4 @@data: (settings) => settings.hideMembershipEvents ? true : false,));if (event.type == "m.room.member" && hideMembershipEvents) {Better check the type of content instead of a string, e.g.
event.content is MembershipContent