WIP: Support for pinned messages #49

istalri · 2026-07-06T18:58:57-04:00

istalri commented

2026-07-06 18:58:57 -04:00

The first draft to support pinned messages. Fixes #39.

TODO:

Check if filtering is necessary for visibility rules and implement it
Add pin/unpin to context menu

The first draft to support pinned messages. Fixes #39. TODO: - [ ] Check if filtering is necessary for visibility rules and implement it - [ ] Add pin/unpin to context menu

istalri added 1 commit

2026-07-06 18:58:58 -04:00

First Draft: Support for pinned messages. a2d2aeca7a

Henry-Hiles added 3 commits

2026-07-06 20:11:23 -04:00

rename RoomsPinsController to PinnedEventsController 5bdf5d06b1

rename PinnedMessages to PinnedEventsDrawer 5c78cc85f7

cleanup PinnedEventsController 177c057337

Henry-Hiles commented

2026-07-06 20:14:44 -04:00

Hope you don't mind me pushing some small cleanups to your branch ^

Henry-Hiles requested changes

2026-07-06 20:14:48 -04:00

lib/models/requests/send_event_request.dart

					
				@ -8,6 +8,7 @@ abstract class SendEventRequest with _$SendEventRequest {

				    required String roomId,

				    required String type,

				    required Map<String, dynamic> content,

				    @Default(null) String? stateKey,

Not certain where you got this from... It's not valid: https://spec.mau.fi/gomuks/rpc.html#cmd-send-event

Instead, set_state must be used. This will need its own function in ClientController.

Not certain where you got this from... It's not valid: https://spec.mau.fi/gomuks/rpc.html#cmd-send-event Instead, [`set_state`](https://spec.mau.fi/gomuks/rpc.html#cmd-set-state) must be used. This will need its own function in `ClientController`.

Oh then I understood something wrong. I though it was needed for this:

Matrix Spec:

{
"content": {
"pinned": [
"$someevent:example.org"
]
},
"event_id": "$143273582443PhrSn:example.org",
"origin_server_ts": 1432735824653,
"room_id": "!jEsUZKDJdhlrceRyVU:example.org",
"sender": "@example:example.org",
"state_key": "",
"type": "m.room.pinned_events",
"unsigned": {
"age": 1234,
"membership": "join"
}
}

Oh then I understood something wrong. I though it was needed for this: Matrix Spec: > { > "content": { > "pinned": [ > "$someevent:example.org" > ] > }, > "event_id": "$143273582443PhrSn:example.org", > "origin_server_ts": 1432735824653, > "room_id": "!jEsUZKDJdhlrceRyVU:example.org", > "sender": "@example:example.org", > "state_key": "", > "type": "m.room.pinned_events", > "unsigned": { > "age": 1234, > "membership": "join" > } > }

Ah, well eventually it gets to Matrix, but we actually use gomuks as an SDK essentially, so we use that to e.g. send events. You can reference their docs for a schema of all commands: https://spec.mau.fi/gomuks/rpc.html

👍 1

Okay, I see. I will look into it.

Edit: Just read the gomuks spec, seems the set_state is straight forward. At first I was not sure why there needs to be multiple endpoints for events but I then it clicked and yeah it makes sense to separate state events from other events. Although I think it's slightly misleading to have send_event and set_state and not send_state_event or the other way around have also set_reaction etc but maybe that's just me.

Okay, I see. I will look into it. Edit: Just read the gomuks spec, seems the `set_state` is straight forward. At first I was not sure why there needs to be multiple endpoints for events but I then it clicked and yeah it makes sense to separate state events from other events. Although I think it's slightly misleading to have `send_event` and `set_state` and not `send_state_event` or the other way around have also `set_reaction` etc but maybe that's just me.

Henry-Hiles changed title from ~~WIP: Support for pinned messages.~~ to WIP: Support for pinned messages

2026-07-06 20:15:18 -04:00

Henry-Hiles requested changes

2026-07-06 20:19:11 -04:00

lib/widgets/pinned_events_drawer.dart Outdated

					
				@ -0,0 +50,4 @@

				                ],

				              ),

				            ),

				            AsyncData(:final value) => ListView.builder(

I would say instead of this, a SuperSliverView should be used, like we do in the main chat view, and instead of an extra card, just wrap EventRenderer with an InkWell or something. And then, you don't need to set textOnly on EventRenderer.

I would say instead of this, a `SuperSliverView` should be used, like we do in the main chat view, and instead of an extra card, just wrap `EventRenderer` with an `InkWell` or something. And then, you don't need to set `textOnly` on `EventRenderer`.

Okay, I take it back about SuperSliverView, the performance of ListView seems acceptable here.

Okay, I take it back about `SuperSliverView`, the performance of `ListView` seems acceptable here.

I've done my other suggestion with not using textOnly.

I've done my other suggestion with not using `textOnly`.

Henry-Hiles marked this conversation as resolved

Henry-Hiles requested changes

2026-07-06 20:20:45 -04:00

lib/widgets/room_chat.dart Outdated

					
				@ -511,1 +521,3 @@

				      endDrawer: showMembersByDefault ? null : MemberList(roomId),

				      endDrawer: showMembersByDefault && memberListOpened.value

				          ? null

				          : Drawer(

This isn't a good way to do this, the double scaffold is better. I will push a fix.

Done.

Henry-Hiles marked this conversation as resolved

Henry-Hiles added 1 commit

2026-07-06 20:36:52 -04:00

use a double scaffold approach for pins drawer 1f776c2a77

Henry-Hiles added 2 commits

2026-07-06 20:37:34 -04:00

remove duplicate center cf544cb8e2

use ErrorDialog to show errors 8711fc2099

Henry-Hiles added 2 commits

2026-07-06 20:42:28 -04:00

use EventRenderer card for pins 92f53c9aca

use stale data if needed instead of showing loading in pinned events drawer 81bf1a8302

Henry-Hiles requested changes

2026-07-06 20:45:49 -04:00

lib/controllers/pinned_events_controller.dart Outdated

					
				@ -0,0 +41,4 @@

				    return .new();

				  }

				  Future<void> togglePin(Event event) async {

I think I'd prefer a removePin and addPin, separate methods. And of course this needs to be called from the context menu. The context menu should have an option of "Pin" if the event is not pinned (not present in pinned events controller), and you have permission to pin, or "Unpin" if the event IS pinned, and you have permission to pin.

I think I'd prefer a `removePin` and `addPin`, separate methods. And of course this needs to be called from the context menu. The context menu should have an option of "Pin" if the event is not pinned (not present in pinned events controller), and you have permission to pin, or "Unpin" if the event IS pinned, and you have permission to pin.

Yeah, makes sense, seperation of concern is a useful standard. This would make it cleaner.

istalri commented

2026-07-07 03:15:37 -04:00

@Henry-Hiles wrote in #49 (comment):

Hope you don't mind me pushing some small cleanups to your branch ^

I like the changes, seeing it with rested eyes, I can say I left quite the mess. I will look at it in more detail this evening/night but it looks nice on first glance. THe double Scaffold is required for having the pin drawer above the member list on pc, not sure how this will work exactly on mobile, can I open both simultaneously?

@Henry-Hiles wrote in https://git.federated.nexus/Nexus/nexus/pulls/49#issuecomment-404: > Hope you don't mind me pushing some small cleanups to your branch ^ I like the changes, seeing it with rested eyes, I can say I left quite the mess. I will look at it in more detail this evening/night but it looks nice on first glance. THe double Scaffold is required for having the pin drawer above the member list on pc, not sure how this will work exactly on mobile, can I open both simultaneously?

Henry-Hiles commented

2026-07-07 11:20:33 -04:00

not sure how this will work exactly on mobile, can I open both simultaneously?

No, because both are drawers on mobile. So, one being open hides the button to open the other.

> not sure how this will work exactly on mobile, can I open both simultaneously? No, because both are drawers on mobile. So, one being open hides the button to open the other.

❤️ 1

Henry-Hiles added 1 commit

2026-07-07 15:48:56 -04:00

add macos folder a241530f34

Henry-Hiles force-pushed support_pinned_messages from a241530f34 to 81bf1a8302

2026-07-07 15:49:49 -04:00

Compare

Henry-Hiles commented

2026-07-07 16:40:59 -04:00

Note: I didn't mean to push that commit "add macos folder" to this branch, I have force pushed to remove it :)

My fault!

Note: I didn't mean to push that commit "add macos folder" to this branch, I have force pushed to remove it :) My fault!

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u support_pinned_messages:istalri-support_pinned_messages

git switch istalri-support_pinned_messages

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff istalri-support_pinned_messages

git switch istalri-support_pinned_messages

git rebase main

git switch main

git merge --ff-only istalri-support_pinned_messages

git switch istalri-support_pinned_messages

git rebase main

git switch main

git merge --no-ff istalri-support_pinned_messages

git switch main

git merge --squash istalri-support_pinned_messages

git switch main

git merge --ff-only istalri-support_pinned_messages

git switch main

git merge istalri-support_pinned_messages

git push origin main

Sign in to join this conversation.

No reviewers

No labels

Blocked

Good First Issue

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Nexus/nexus!49

Rows
Columns