Nexus/nexus
Nexus/nexus
4
4
Fork 5
Code Issues 14 Pull requests 2 Projects Releases Packages Wiki Activity

WIP: Support for pinned messages #49

Draft
istalri wants to merge 9 commits from istalri/nexus:support_pinned_messages into main
pull from: istalri/nexus:support_pinned_messages
merge into: Nexus:main
Conversation 8 Commits 9 Files changed 7 +2 -1
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 81bf1a8302 - Show all commits

use stale data if needed instead of showing loading in pinned events drawer

Prev Next
Henry Hiles 2026-07-06 20:42:25 -04:00
commit 81bf1a8302
Signed by: Henry-Hiles
SSH key fingerprint: SHA256:VKQUdS31Q90KvX7EkKMHMBpUspcmItAh86a+v7PGiIs

3
lib/widgets/pinned_events_drawer.dart
View file

@ -51,7 +51,8 @@ class PinnedEventsDrawer extends HookConsumerWidget {
],
),
),
Henry-Hiles marked this conversation as resolved Outdated
Henry-Hiles commented 2026-07-06 20:19:10 -04:00
Outdated
Copy link

I would say instead of this, a SuperSliverView should be used, like we do in the main chat view, and instead of an extra card, just wrap EventRenderer with an InkWell or something. And then, you don't need to set textOnly on EventRenderer.

I would say instead of this, a `SuperSliverView` should be used, like we do in the main chat view, and instead of an extra card, just wrap `EventRenderer` with an `InkWell` or something. And then, you don't need to set `textOnly` on `EventRenderer`.
Henry-Hiles commented 2026-07-06 20:42:55 -04:00
Outdated
Copy link

Okay, I take it back about SuperSliverView, the performance of ListView seems acceptable here.

Okay, I take it back about `SuperSliverView`, the performance of `ListView` seems acceptable here.
Henry-Hiles commented 2026-07-06 20:43:06 -04:00
Outdated
Copy link

I've done my other suggestion with not using textOnly.

I've done my other suggestion with not using `textOnly`.
AsyncData(:final value) => ListView.builder(
AsyncData(:final value) ||
AsyncLoading(:final value?) => ListView.builder(
padding: .symmetric(horizontal: 8),
itemCount: value.length,
itemBuilder: (context, index) {