Nexus/nexus
Nexus/nexus
Watch
4
5
Fork
You've already forked nexus
 6
Code Issues 15 Pull requests 1 Projects Releases Packages Wiki Activity

feat: Add iOS platform support #60

Merged
Henry-Hiles merged 7 commits from eleboucher/nexus:ios-support into main 2026-08-08 16:35:57 -04:00
Conversation 2 Commits 7 Files changed 66 +1699 -58
eleboucher commented 2026-08-08 15:41:35 -04:00
Contributor
Copy link
No description provided.
Henry-Hiles requested changes 2026-08-08 16:07:30 -04:00
Henry-Hiles left a comment
Copy link

just one small nitpick :)

just one small nitpick :)
hook/build.dart Outdated
@ -20,0 +28,4 @@
final iosConfig = codeConfig.iOS;
iosSdk = iosConfig.targetSdk;
final minVersion = iosConfig.targetVersion;
iosSdkPath = (await Process.run("xcrun", [
Henry-Hiles commented 2026-08-08 16:05:12 -04:00
Owner
Copy link

Failures should be handled here. Maybe you can edit lib/helpers/extensions/get_xcode_sdk.dart to take in a {String? sdkType} and just use that?

Failures should be handled here. Maybe you can edit `lib/helpers/extensions/get_xcode_sdk.dart` to take in a `{String? sdkType}` and just use that?
Henry-Hiles marked this conversation as resolved
hook/build.dart Outdated
@ -20,0 +45,4 @@
: "$archTriple-apple-ios$minVersion.0";
extraEnv = {
"GOOS": "ios",
"CC": (await Process.run("xcrun", [
Henry-Hiles commented 2026-08-08 16:05:55 -04:00
Owner
Copy link

Same here :)

Same here :)
Henry-Hiles marked this conversation as resolved
Henry-Hiles requested changes 2026-08-08 16:26:42 -04:00
lib/helpers/extensions/get_xcode_sdk.dart Outdated
@ -12,0 +19,4 @@
if (sdkType != null) ...["--sdk", sdkType],
"-f",
"clang",
], "get XCode clang");
Henry-Hiles commented 2026-08-08 16:26:40 -04:00
Owner
Copy link

Sorry for another nitpick but instead of splitting this into multiple methods can we not just Future<String> getXCodeTool({String? sdkType, String? findTool}) and then use e.g. getXCodeTool(iosSdk.type, "clang")?

Sorry for another nitpick but instead of splitting this into multiple methods can we not just `Future<String> getXCodeTool({String? sdkType, String? findTool})` and then use e.g. `getXCodeTool(iosSdk.type, "clang")`?
eleboucher marked this conversation as resolved
Sign in to join this conversation.
Reviewers
No reviewers
Henry-Hiles
Labels
Clear labels
  
Blocked
Blocked based on something external to Nexus

  
Good First Issue
Easy to fix for newcomers

No labels
Blocked
Good First Issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Nexus/nexus!60
No description provided.