mirrors/qmk_userspace
1
0
Fork 1
mirror of https://github.com/qmk/qmk_userspace.git synced 2026-04-22 11:30:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Revert code review suggestions that broke Vial combo introspection

Browse source 
The Keebart Vial fork requires combos to be in the same compilation
unit as the keymap (via #include KEYMAP_C introspection). The Copilot
code review suggested removing #include "timfee.c" from keymap.c and
re-adding SRC += timfee.c to rules.mk, which broke this mechanism.

Restore the working state: include timfee.c directly in keymap.c and
remove the separate SRC compilation.

Agent-Logs-Url: https://github.com/timfee/qmk_userspace/sessions/6c6892d3-5ab0-46b6-8c6c-7a1490274312

Co-authored-by: timfee <3246342+timfee@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-04-12 21:35:08 +00:00 • committed by GitHub
commit 6a499d0ae9
Failed to generate hash of commit
2 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
keyboards/keebart/corne_choc_pro/keymaps/timfee/keymap.c
View file

@ -1,4 +1,5 @@
#include "timfee.h"
#include "timfee.c"
const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {

1
users/timfee/rules.mk
View file

@ -1,2 +1 @@
COMBO_ENABLE = yes
SRC += timfee.c